Handle paths illegal on Windows in ImageDescriptor.createFromFile() #2946
+6
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle filenames, that are used as file-system paths because the context class is null and are illegal on Windows, for example like: /C:/data/other This happens if retrieved from a URL/URI by just using 'URL/URI.getPath()' instead of using 'Path.of(uri)' or 'new File(uri)'. Using IPath.fromOSString() instead of Path.of(), allows to use these kind of illegal paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle filenames, that are used as file-system paths because the context class is null and are illegal on Windows, for example like:
/C:/data/otherThis happens if retrieved from a URL/URI by just using
URL/URI.getPath()instead of usingPath.of(uri)ornew File(uri).Using
IPath.fromOSString()instead ofPath.of(), allows to use these kind of illegal paths.This fixes the test-failure introduced in